Skip to content

Conversation

@isuniverseok-ua
Copy link
Contributor

PR description

The issue was because we only enabled the txn pool after initial sync completed. In a Holesky shadow fork, initial sync can remain “not done” even after Merge, so the pool stayed disabled while we still imported/produced blocks. Result: empty blocks despite network activity. To fix this I enabled the txn pool as soon as TTD is reached (post-merge), even if initial sync isn’t complete. Now also I subscribe to the 'TTD-reached' event so the pool flips on immediately when that happens and keeping P2P txn gossip handlers gated on “in-sync” exactly as before.

Why this fixes the issue

After TTD, block building relies on the tx pool. With the pool enabled, locally submitted transactions can be accepted and included, so we stop producing empty blocks during the shadow fork window. Gossip stays off until we’re in-sync, so we don’t risk propagating/accepting out-of-sync traffic. Safety is unchanged; we only allow local acceptance and block inclusion.

Fixed Issue(s)

fixes #9240

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tx pool not enabled in holesky shadow fork

2 participants