Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global config #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove global config #136

wants to merge 1 commit into from

Conversation

dongrie
Copy link
Contributor

@dongrie dongrie commented Mar 6, 2024

  • Remove global config from Config
  • Add flags to CLI

@dongrie
* Remove global config
c286d02 
* Add flags

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from a team as a code owner March 6, 2024 02:43
@dongrie
Copy link
Contributor Author

dongrie commented May 14, 2024

@siburu Can I close this PR if it's being addressed elsewhere?

@siburu
Copy link
Contributor

siburu commented May 14, 2024 •
edited
Loading

@dongrie The review is late but the PR itself is still valid.

if it's being addressed elsewhere

No, it's not being addressed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dongrie @siburu