refactor: Umbrella Iroha CLI #5282
Draft
+508
−553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
aoyako
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
github-actions
bot
added
the
config-changes
s8sato
reviewed
Jan 20, 2025
Cargo.toml
Outdated
| @@ -49,6 +49,8 @@ iroha_executor_data_model = { version = "=2.0.0-rc.1.0", path = "crates/iroha_ex | |||
| iroha_test_network = { version = "=2.0.0-rc.1.0", path = "crates/iroha_test_network" } | |||
| iroha_test_samples = { version = "=2.0.0-rc.1.0", path = "crates/iroha_test_samples" } | |||
|
|
|||
| iroha_swarm = { version = "=2.0.0-rc.1.0", path = "crates/iroha_swarm" } | |||
There was a problem hiding this comment.
How about directly specifying this as a iroha_kagami dependency, not as a workspace dependency?
There was a problem hiding this comment.
You are right. It is not needed here unless used externally.
There was a problem hiding this comment.
inquire also would be removed from workspace dependencies
Signed-off-by: Lohachov Mykhailo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4969
This PR begins the unification of cli tools into the iroha/kagami tools.
#4969 (comment)
#4969 (comment)
#4969 (comment)
Changes introduced extend the default scope of kagami by adding:
codec(types, json-to-scale, scale-to-json, scale-to-rust)wasm(from wasm_builder)kura(from kura_inspector)swarm(from iroha_swarm)Documentation in the readme is updated as well. I believe the documentation update on the website will be updated afterward.
The
swarmandwasm_builderlibraries are left intact in case they are later reused in the code.