fix: Replace use of Duration for timestamps with an actual timestamp, e.g. chrono::DateTime #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollermay
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
hollermay
changed the title
hollermay
changed the title
mversic
requested changes
Jun 23, 2024
Co-authored-by: Marin Veršić <[email protected]> Signed-off-by: Udayan S. <[email protected]>
Co-authored-by: Marin Veršić <[email protected]> Signed-off-by: Udayan S. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue number #4729
Before resolving:
After resolving the issue
Also, apart from this I made the required changes that involved changing of start to start_ms and since to since_ms.