Skip to content

Integrate supplementary Protocol Buffers (protobuf) parameters into the JS client to augment the extensibility and functionality of the data model within the designated oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: iroha1-main
Choose a base branch
from

Conversation

baziorek
Copy link

This is PR with changes from: #181

Incorporate additional Protocol Buffers (protobuf) parameters into the JS client, enhancing the extensibility and functionality of the data model within the specified 'oneof' constructs. This integration ensures a more comprehensive representation and utilization of transaction-related information, thereby expanding the capabilities and flexibility of the system.

Those changes are connected with: hyperledger-iroha/iroha#4003 - this is part of internship project:
https://wiki.hyperledger.org/pages/viewpage.action?pageId=80778614

…age communication, with corresponding handling capabilities in Iroha CLI.

Signed-off-by: dominious1 <[email protected]>
@baziorek
Copy link
Author

This code should be tested by somebody who knows TypedScript (or rather is fluent with TypedScript). There should be made similar steps as for iroha-python: hyperledger-iroha/iroha-python#157 (comment)

  1. First of all server must be running. Here is instruction how to build its by its own: https://wiki.hyperledger.org/pages/viewpage.action?pageId=98731447 (official docker images are quite old, but required changes are new)
  2. The library from the branch should be installed git clone https://github.com/baziorek/iroha-javascript.git -b baziorek:proto_from_tomasz (not from official package repository)
  3. Then client must be prepared:
    1. Here is example code: https://github.com/hyperledger/iroha-javascript/blob/main/example/index.ts
    2. In the code we need only: 2 commands: https://iroha.readthedocs.io/en/main/develop/api/commands.html#add-asset-quantity and https://iroha.readthedocs.io/en/main/develop/api/commands.html#subtract-asset-quantity (they are not used in example), but with extra parameter "description". The next thing is to query transactions (it is in the example): https://github.com/baziorek/iroha-javascript/blob/968bd48c87de614da9a50b6b86dc839b274ce9a7/example/index.ts#L94
  4. If we see that newly introduced parameter "description" is available - it means that the PR is correct and can be merged.

Copy link
Contributor

@6r1d 6r1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x009922 0x009922 changed the base branch from main to iroha1-main February 19, 2025 02:51
@0x009922
Copy link
Contributor

@baziorek is this still relevant to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants