This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Feature/mst shared limit #2230
Open
Feature/mst shared limit #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBoldyrev
added
needs-review
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
MBoldyrev
force-pushed
the
feature/mst-shared-limit
branch
from
53a93e7 to
b83b172
Compare
igor-egorov
approved these changes
Apr 16, 2019
| if (not pcs_->propagate_batch(moved_batch->get())) { | ||
| if (not pending_batches_.insert(std::move(moved_batch))) { | ||
| log_->critical( | ||
| "Dropped a completed MST batch because no place left in storage: {}", |
There was a problem hiding this comment.
Usually, space is used in that context (even if place is more technically correct because it is internals that are not an object of interest for the external interface user).
Suggested change
| "Dropped a completed MST batch because no place left in storage: {}", | |
| "Dropped a completed MST batch because no space left in storage: {}", |
|
|
||
| bool MstToPcsPropagation::InternalStorage::insert(BatchPtr batch) { | ||
| pending_batches.emplace_back(std::move(batch)); | ||
| return true; |
There was a problem hiding this comment.
Unconditional return type 🤔
| auto completed_batches = batches_.move([this, &state_update, &rhs_batch]( | ||
| auto &storage) | ||
| -> std::vector<BatchPtr> { | ||
| auto corresponding = storage.batches.right.find(rhs_batch); |
There was a problem hiding this comment.
I would be very glad if you will use any other variable name instead of "corresponding". Hope this is possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Reworked completed MST batches propagation to PCS:
MstToPcsPropagationMstToPcsPropagationtries to pass them to PCSMstToPcsPropagationwaits till a notification with available room for transactions and resends the fitting batchesMstToPcsPropagationuses the same shared limit with the rest MST batches storages, which prevents new batches from being accepted until previously accepted either expire or come to PCS.Benefits
Solves the memory growth problem.
Possible Drawbacks
Usage Examples or Tests [optional]
Please see
mst_to_psc_propagation_test.Alternate Designs [optional]