Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Feature/iroha build time graph #2069

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Stayer
Copy link
Contributor

@Stayer Stayer commented Jan 31, 2019

Description of the Change

[DOPS-116]
This PR allows to view compilation time per target (g++ run time) per each build for all branches, and compare this time to develop tree. After that we have csv file with time difference in seconds and %

Benefits

Developers can detail view and compare time to improve their code.

Possible Drawbacks

  1. For now it is not possible to print cmake output to jenkins console (using tee gives some duplicates in the result file)
  2. When "fuzzingEnabled" is true, there is no results

Usage Examples or Tests [optional]

See attachment diff.csv.zip

Alternate Designs [optional]

@Stayer Stayer added needs-correction pr/rfc is not completed and might be updated infrastructure anything related to continious integration, building infrastructure, or cmake labels Jan 31, 2019
@Stayer Stayer requested review from bakhtin and lebdron January 31, 2019 15:00
Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
@bakhtin

This comment has been minimized.

@BulatSaif BulatSaif self-requested a review February 8, 2019 07:30
@Stayer Stayer added needs-review pr awaits review from maintainers and removed needs-correction pr/rfc is not completed and might be updated labels Feb 8, 2019
@Stayer Stayer force-pushed the feature/iroha_build_time_graph branch from b58abc3 to ab94778 Compare February 8, 2019 07:50
@BulatSaif

This comment has been minimized.

@Stayer

This comment has been minimized.

@BulatSaif

This comment has been minimized.

@BulatSaif
Copy link
Contributor

as I understand it will no work with clang?

@Stayer Stayer removed the needs-review pr awaits review from maintainers label Feb 19, 2019
@Stayer
Copy link
Contributor Author

Stayer commented Feb 19, 2019

as I understand it will no work with clang?

yes, you are right

@Stayer Stayer force-pushed the feature/iroha_build_time_graph branch from 559e532 to cf71e0a Compare February 21, 2019 13:27
@Stayer Stayer added the needs-review pr awaits review from maintainers label Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infrastructure anything related to continious integration, building infrastructure, or cmake needs-review pr awaits review from maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants