Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment PR #502

Draft
wants to merge 386 commits into
base: empty
Choose a base branch
from

iroha2-branding (#511)

90cf675
Select commit
Loading
Failed to load commit list.
Draft

Comment PR #502

iroha2-branding (#511)
90cf675
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Dec 4, 2024 in 2s

Check failed

There are 51 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 3dfe00f [documentation]: Review peer management Valid sign-off found
🟢 2dac246 Apply suggestions from code review Valid sign-off found
🟢 b4c2297 [documentation]: Review the Triggers chapter (#65) Valid sign-off found
🟢 520e5dd [documentation]: Review the Queries chapter Valid sign-off found
🟢 eba668d Update src/guide/advanced/queries.md Valid sign-off found
🟢 ac6bfb0 Update src/guide/advanced/queries.md Valid sign-off found
🟢 15c3967 Review Bash chapter Valid sign-off found
🟢 3e0bf47 Review JS chapter Valid sign-off found
🟢 b583fd3 Review Kotlin chapter Valid sign-off found
🟢 86855a5 Review Python chapter Valid sign-off found
🟢 1abc9b8 Review Rust chapter Valid sign-off found
🟢 e8d3bbf Add minor changes to lang-specific chapters Valid sign-off found
🟢 158789a Apply suggestions from code review Valid sign-off found
🟢 4de14b2 Fix formatting Valid sign-off found
🟢 459743e [documentation]: Review the Iroha 2 vs. Iroha 1 ch... Valid sign-off found
🟢 f295b73 Rephrase the intro Valid sign-off found
🟢 e8f2aea [documentation]: Review Installation chapter Valid sign-off found
🟢 985f0eb Apply suggestions from code review Valid sign-off found
🟢 c7eebf2 Fix formatting Valid sign-off found
🟢 f4f4ded Apply suggestions from code review Valid sign-off found
🟢 b513876 Revert changes Valid sign-off found
🟢 88cd287 Fix formatting Valid sign-off found
🟢 6ce8ed2 [documentation]: Review Iroha on bare metal chapte... Valid sign-off found
🟢 2d3215e Apply suggestions from code review Valid sign-off found
🟢 70ebd66 Fix formatting Valid sign-off found
🟢 cda8e50 Apply suggestions from code review Valid sign-off found
🟢 fa9d610 Revert changes (quotation mark) Valid sign-off found
🟢 e3d05d8 Fix formatting Valid sign-off found
🟢 3fe53d7 [CI]: target main branch in GitHub workflows Valid sign-off found
🟢 abcc32e Merge pull request #72 from 0x009922/fix-workflows Skipped: sign-off not required in merge commit
🟢 dd12623 #73, #60: Update info about roles, mark statements... Valid sign-off found
🟢 59d3f57 Fix docker-compose command Valid sign-off found
🟢 4701401 [docs]: update version note in js guide (#74) Valid sign-off found
🟢 2c3af5a Merge pull request #80 from 6r1d/main Skipped: sign-off not required in merge commit
🟢 4f463c3 Add FindTriggersByDomainId query (#75) Valid sign-off found
🟢 0740e68 [docs] Update JS examples Valid sign-off found
🟢 26e4fd4 Merge pull request #91 from 6r1d/main Skipped: sign-off not required in merge commit
🟢 c2b69fa update all deps, migrate to vitepress@1 Valid sign-off found
🟢 72bb16d [misc]: update deps, up to vitepress alpha 4 Valid sign-off found
🟢 3401fd0 [style]: update brand colors Valid sign-off found
🟢 c18b654 [feat]: generate favicon Valid sign-off found
🟢 44623a2 [docs] #79: Add block queries Valid sign-off found
🟢 4ef4edd Update parameter Valid sign-off found
🟢 b2dc26f Fix formatting Valid sign-off found
🟢 304e6ca Add versioning boxes Valid sign-off found
🟢 32560c2 [docs] update JS code samples Valid sign-off found
🟢 919e6ed [docs] Add a Kagami note Valid sign-off found
🟢 5a3688e Update code snippet in Rust guide Valid sign-off found
🟢 a39908d Add Victor as a codeowner (#103) Valid sign-off found
🟢 f8f1db5 [docs] #97: Add a note about compatibility of Iroh... Valid sign-off found
🟢 5c55b86 [docs] #96: Add a topic about permissions (#100) Valid sign-off found
🟢 950a1c4 [docs] #59: Update statements about triggers Valid sign-off found
🟢 42295df [docs] #95: Update Python asset metadata example (... Valid sign-off found
🟢 7314da0 [docs] #107: Add FindAllPermissionTokenDefinitions... Valid sign-off found
🟢 d902736 [docs] #105: Add a section on domain-scoped trigge... Valid sign-off found
🟢 bd6328d [docs] #39, #83, #90: Update WASM/FFI guide (#114) Valid sign-off found
🟢 8213cd2 [docs] #116: Add openssl installation instructions... Valid sign-off found
🔴 e0287a5 [docs] #120: Update JS installation instruction (#... Sign-off not found
🔴 513cb67 [docs]: Update install instructions (#117) Sign-off not found
🟢 0f68bc6 [docs]: Update JS install (#123) Valid sign-off found
🟢 507daa3 [docs] #121, #125: Update JS guide (#126) Valid sign-off found
🟢 a2e450b [docs] #129: Add a note about iroha-javascript rep... Valid sign-off found
🟢 c6679c9 Apply suggestions from code review Valid sign-off found
🟢 5155b23 [reword]: Simplify and remove unclear clarificatio... Valid sign-off found
🟢 7cd1338 [version_bump]: Fix major outdated versions in tut... Valid sign-off found
🟢 6671dad [version_bump]: Update rust tutorial. Valid sign-off found
🟢 5b554a4 Apple @outoftardis suggestions Valid sign-off found
🟢 aff43e7 [ci]: Create MAINTAINERS.md Valid sign-off found
🟢 881a260 [docs] #127: Fix git clone in Python guide Valid sign-off found
🟢 a2382d0 [docs]: Add info about metadata and sorting Valid sign-off found
🟢 544fef4 [docs] #125: Update JS guide Valid sign-off found
🟢 270a2e8 Add instructions Valid sign-off found
🟢 c6ce6d9 Update jpg Valid sign-off found
🟢 565577d Update markup Valid sign-off found
🟢 3884245 Apply suggestions from code review Valid sign-off found
🟢 35f93b2 Fix spelling Valid sign-off found
🟢 f6e50db [docs] #129: Add a note about iroha-javascript rep... Valid sign-off found
🟢 3a619cd [fix]: broken link preventing deploy Valid sign-off found
🟢 42f17c5 [fix]: Update index, rust guide, and install chapt... Valid sign-off found
🟢 1e5ffb6 [docs] #141: Add mentions of other docker-compose ... Valid sign-off found
🟢 448dad4 Fix formatting Valid sign-off found
🟢 f81e7f2 Fix JS guide (commit history mixup) Valid sign-off found
🟢 d87df75 Address comments Valid sign-off found
🟢 db07d95 [docs] #144: Fix Python script Valid sign-off found
🟢 018466f [fix]: Fix typo in Bash guide Valid sign-off found
🟢 3d13ae8 Fix output Valid sign-off found
🟢 394b132 Hide output Valid sign-off found
🟢 1592f50 [docs] #85: Add UML diagrams, create a new chapter... Valid sign-off found
🟢 de7e532 [ci]: run build in PR CI as well (#150) Valid sign-off found
🟢 b07d88b [docs] #111: Add info about permission validators ... Valid sign-off found
🟢 b51a9dd [docs] #160: Update links (#164) Valid sign-off found
🟢 d9e22fb [docs]: Change default BLOCK_STORE_PATH location Valid sign-off found
🟢 7414be0 [fix]: Fix a typo Valid sign-off found
🟢 6fa2935 [docs]: Update FFI chapter (#158) Valid sign-off found
🟢 d8374a8 [docs] #166: Add the location of build artifacts Valid sign-off found
🟢 b5ecf41 [docs] #85: Add diagrams for triggers and filters ... Valid sign-off found
🟢 0499867 [docs]: remove obsolete comment Valid sign-off found
🟢 316c8f0 [docs]: Add a link to the test network Valid sign-off found
🟢 2d9437b [docs] #162: Update Wasm chapter Valid sign-off found
🟢 966be70 [docs] #170: Update client config page (#176) Valid sign-off found
🟢 dfc9863 [docs] #161: Add more info about ISI Valid sign-off found
🟢 1eccfb1 Apply suggestions from code review Valid sign-off found
🟢 e77ca64 Apply suggestions from code review Valid sign-off found
🟢 8653a1e Update src/guide/advanced/intro.md Valid sign-off found
🟢 9188081 Update src/guide/advanced/isi.md Valid sign-off found
🟢 6cc7482 Fix formatting Valid sign-off found
🟢 c95b072 Apply suggestions from @WRRicht3r Valid sign-off found
🟢 9ee3789 [fix] #146: update snippets in python section Valid sign-off found
🟢 31c4829 [docs] #89: Add scripts, Vue component, parser ext... Valid sign-off found
🟢 3c643a6 [docs] #81: Add example on transferring assets to ... Valid sign-off found
🟢 ad54fca [docs]: update JavaScript tutorial according to th... Valid sign-off found
🟢 8c1d95b [ci]: boost CI with cache; refactor formatting and... Valid sign-off found
🟢 bdb15f6 [docs] #191: Update triggers page Valid sign-off found
🟢 fbbb13e Update src/guide/advanced/triggers.md Valid sign-off found
🟢 17e8911 [docs] #197: Optimize the number of steps on the b... Valid sign-off found
🟢 a83013b [docs] #174: Update documentation after RC-9 (LTS)... Valid sign-off found
🔴 7fe2ec4 [docs] Add a missing cd command (#201) No sign-off matches the author or committer
🟢 6d83453 [docs] #182: Update peer config page Valid sign-off found
🟢 aeb1bb0 [docs]: Move files from main repo Valid sign-off found
🟢 a28b106 Fix links Valid sign-off found
🟢 2bac1ee Update toc Valid sign-off found
🟢 89e75c3 Update src/guide/glossary.md Valid sign-off found
🟢 2f4f726 Address comments Valid sign-off found
🟢 ba9d2d4 [docs]: #149, #180: Add JS examples (block stream ... Valid sign-off found
🟢 2d9702c [docs] #193: Update instructions page, add a page ... Valid sign-off found
🟢 8cee36f Apply suggestions from code review Valid sign-off found
🟢 e750ace Apply suggestion Valid sign-off found
🟢 5ce42dc FFI doc update Valid sign-off found
🟢 cc6db01 Apply suggestions from code review Valid sign-off found
🟢 253aaf4 Apply suggestions from code review Valid sign-off found
🟢 f403561 [docs]: Update FFI chapter Valid sign-off found
🟢 09565a3 Apply suggestions from code review Valid sign-off found
🟢 1f876a6 Fix formatting Valid sign-off found
🔴 4bef66b Add a Kotlin snapshot selection section (#210) Sign-off not found
🔴 a3f60f9 Redefine a Kotlin configuration (#212) No sign-off matches the author or committer
🔴 c7feb4f Redefine a Kotlin configuration (#212) (#214) Sign-off not found
🟢 97beef9 [docs] #159, #171, #179: Update config sections (#... Valid sign-off found
🟢 e8960ac [docs] #216: Add client_cli subcommands (#217) Valid sign-off found
🟢 9fcb1ab [docs] #221: Add json subcommand (#222) Valid sign-off found
🟢 5dc82de [docs] #218: Document Iroha versions (#220) Valid sign-off found
🟢 10848df [docs] #190: Document MetadataChanged (#223) Valid sign-off found
🟢 6d18045 [docs]: Create a troubleshooting section (#219) Valid sign-off found
🟢 7ee9342 [docs] #215: Update asset queries (#230) Valid sign-off found
🟢 34a7714 [docs] #227: Update pure Java example (#228) Valid sign-off found
🟢 17c6ec9 [docs] #226: Update permission_token.json exampl... Valid sign-off found
🟢 cadebed [docs] #175: Split tutorial and reference document... Valid sign-off found
🟢 9f39616 [refactor]: introduce full-featured code groups (#... Valid sign-off found
🟢 6b3d14d [refactor] #225: redesign snippets workflow (#232) Valid sign-off found
🔴 04fe6cb [fix]: sample region in lorem.rs (#233) No sign-off matches the author or committer
🟢 2b9e79d [docs]: Add snippets for config files (#236) Valid sign-off found
🟢 aac12ce [fix]: Update config.ts (#238) Valid sign-off found
🟢 8f4aa13 [docs] #2579: Link to Iroha 1 documentation (#235) Valid sign-off found
🔴 42f4e62 [docs] Update links #239 (#240) No sign-off matches the author or committer
🟢 d827a7e [docs] #237: Add instructions on kagami config gen... Valid sign-off found
🔴 afbc663 [docs] Add genesis troubleshooting #241 (#242) Sign-off not found
🔴 ce81fc7 [docs] Extend the glossary (#245) No sign-off matches the author or committer
🟢 1654933 [docs]: Update troubleshooting section, fix format... Valid sign-off found
🟢 04ba142 [docs]: use snippets from `hyperledger/iroha-javas... Valid sign-off found
🔴 14a2fda [docs] #249: Add the support channels (#250) No sign-off matches the author or committer
🟢 49904b7 [docs]: Update snippets (#246) Valid sign-off found
🟢 e91e510 [docs] #252, #256: Update doc structure, add new c... Valid sign-off found
🔴 1512c89 Update VitePress and other dependencies (#265) No sign-off matches the author or committer
🔴 2c037b0 [documentation]: use ANSI code snippet in Quick St... No sign-off matches the author or committer
🟢 443c03d [documentation]: fix small outdated info in JS gui... Valid sign-off found
🔴 ab21082 [style]: use code-format for queries in Permission... No sign-off matches the author or committer
🟢 767751c [style]: format query names as code (#271) Valid sign-off found
🟢 917b8d0 [docs] #261: Update Bash tutorial: key pair genera... Valid sign-off found
🟢 51f0f5e [docs] #267: Update sh-lang code blocks (#268) Valid sign-off found
🟢 fe57d24 Add java snippets (#278) Valid sign-off found
🔴 5760838 [feature]: feedback form (#277) Sign-off not found
🟢 d27600b [fix] #143: update Algolia api key (#283) Valid sign-off found
🔴 01ef9bf [fix]: fix snippet sources revisions (#282) No sign-off matches the author or committer
🔴 05c3ddc [chore]: change feedback form url (#284) (#285) Sign-off not found
🟢 b73c0f2 [feature]: link api_spec from the core repo Valid sign-off found
🟢 5fdbbcb [fix]: exclude snippets/*.md from documentation Valid sign-off found
🟢 555224c [fix]: rewrite relative links in api_spec, fix d... Valid sign-off found
🟢 c8936d1 Update src/api/index.md Valid sign-off found
🟢 930d015 Apply suggestions from code review Valid sign-off found
🟢 f554ebf [fix]: re-write api_spec title Valid sign-off found
🔴 16ddc5e [chore] #289: add iroha_client_cli build link (#29... No sign-off matches the author or committer
🔴 5033385 [chore]: fix typo in path to api_spec on GitHub ... No sign-off matches the author or committer
🟢 f4c8cba [chore] #295: add XDG specification link Valid sign-off found
🟢 19bbf59 [feature] #301: render data model schema (#303) Valid sign-off found
🔴 0439aab [docs] #313: update JS reference to rc13 (#314) No sign-off matches the author or committer
🔴 5251fb0 Corepack (#315) No sign-off matches the author or committer
🔴 932f5b6 [chore]: Add Google Analytics (#244) Sign-off not found
🔴 512ec18 [chore] Update Python SDK version warning (#312) Sign-off not found
🟢 f86ef9d [chore]: stylistic changes (#299) Valid sign-off found
🟢 3b6ad22 Restore new links to text Valid sign-off found
🔴 8a63d2e Update Rust SDK version (related to #308) (#319) No sign-off matches the author or committer
🟢 7839b64 [feature]: add CSD-RTGS stub for link to Matthias Valid sign-off found
🔴 bc2415b [refactor]: migrate from windicss to unocss (#... No sign-off matches the author or committer
🔴 1a62e8e [feature] #307: support Mermaid diagrams (#325) No sign-off matches the author or committer
🔴 e6445d2 [feature] #326: use local search (#327) No sign-off matches the author or committer
🔴 b280572 Metadata and store assets (#318) Sign-off not found
🔴 8883923 Pip update for wheel issue #320 (#322) Sign-off not found
🟢 f01ef5d Added account switching and resolved permission to... Valid sign-off found
🔴 30710f3 updated Iroha 2 Client Setup, Domain search and re... No sign-off matches the author or committer
🟢 3e92fcd changed params Iroha 2 Client Setup, Domain search... Valid sign-off found
🟢 0f1816f update registering and minting assets (#346) Valid sign-off found
🟢 f2b092b update registering an account (#345) Valid sign-off found
🟢 c0cfc67 Add instructions on transferring assets in Kotlin/... Valid sign-off found
🟢 36b90fb Add instructions on burning assets in Kotlin/Java ... Valid sign-off found
🔴 40a3a98 fix last commit (#349) No sign-off matches the author or committer
🟢 a8e2277 Bump word-wrap from 1.2.3 to 1.2.4 Skipped: sign-off not required in bot commit
🟢 615ddec [chore] Fix client config path (#358) Valid sign-off found
🟢 4cd26e7 Bump vite from 4.3.2 to 4.3.9 Skipped: sign-off not required in bot commit
🔴 42b3584 Display the compatibility matrix (#356) No sign-off matches the author or committer
🔴 f2b15b3 [chore]: #381 add @yamkovoy to the MAINTAINERS.md ... Sign-off not found
🟢 fa8a9e2 #354: Fix output value (#393) Valid sign-off found
🔴 197d1ef #395: Explain the use of BASIC_AUTH in the docs (#... Sign-off not found
🔴 8b47120 #399: Add the definition of a peer to the glossary... Sign-off not found
🟢 6afaa01 Typo: use heading 1 in "Consensus" (#403) Valid sign-off found
🔴 e0d0150 [feature]: support TeX math with KaTeX (#404) No sign-off matches the author or committer
🟢 9bc0f28 [feature] #306: Validate links post-build (#405) Valid sign-off found
🟢 a96af16 #406: Remove as Identifiable from examples (#407) Valid sign-off found
🔴 114db71 [feature] #88: Add CI to automatically add labels ... Sign-off not found
🔴 8cc468d Service and theming update (#390) No sign-off matches the author or committer
🟢 e774cc0 [chore]: update Burn<Trigger, u32> warning (#409... Valid sign-off found
🟢 1f903a6 [fix] Update best way to get client cli (#412) Valid sign-off found
🔴 ceeeb1c Update rendered schema (#415) No sign-off matches the author or committer
🔴 5b0eada [docs] #414: move API specification to the docs (#... Sign-off not found
🟢 e2c7f7b Bump postcss from 8.4.27 to 8.4.31 (#420) Skipped: sign-off not required in bot commit
🔴 b5ec854 'Security' section with all topics (#416) No sign-off matches the author or committer
🔴 9c5b37c [docs]: update GET /status reference (#422) No sign-off matches the author or committer
🟢 b689fb6 Add fetch_size query parameter to torii-endpoint... Valid sign-off found
🟢 c01f77d Restructure docs, add home page (#419) Valid sign-off found
🟢 23c52f3 [refactor]: optimize scan, put TODO note Valid sign-off found
🔴 45e3709 Stylistic chores (#433) No sign-off matches the author or committer
🔴 2d8fb9e Security: Navigation and bad syntax bug fix (#438) No sign-off matches the author or committer
🟢 adaa1b9 [docs] #439: Mention that env variables override c... Valid sign-off found
🟢 32c1734 [docs] #437: Mention rejected transactions (#442) Valid sign-off found
🟢 74cd732 [docs]: update configuration endpoints (#435) Valid sign-off found
🟢 67e243d Permission token examples (#467) Valid sign-off found
🟢 150c151 Updated and polished the "Torii Endpoints" topic (... Valid sign-off found
🔴 1572dc1 Housekeeping (#477) No sign-off matches the author or committer
🟢 45f94c4 Update CODEOWNERS (#482) Valid sign-off found
🔴 5ed9fe0 Updated Rust guide to include information about tr... No sign-off matches the author or committer
🟢 5b3f600 Support generating reference for bitmaps in schema Valid sign-off found
🟢 7af87b2 Update to snippets to use the latest iroha dev rev... Valid sign-off found
🟢 a561d6e Update torii reference to be up-to-date with https... Valid sign-off found
🟢 070bb2e Fix broken link to VersionedSignedTransaction (Sig... Valid sign-off found
🟢 61eb82c Stop labeling issues (#488) Valid sign-off found
🟢 c1520e4 Replace docker-compose (V1) with `docker compose... Valid sign-off found
🔴 88c4ce0 Getting started update and overhaul (#504) No sign-off matches the author or committer
🔴 a2df2bf Rename crates iroha_cli and iroha_kagami (#507) Sign-off not found
🔴 a3b05f2 Docs structure overhaul (#508) No sign-off matches the author or committer
🔴 f9d2b58 link fixes due to migration (#509) No sign-off matches the author or committer
🔴 bc65d77 Housekeeping (#510) No sign-off matches the author or committer
🟢 90cf675 iroha2-branding (#511) Valid sign-off found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <[email protected]> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

No sign-off matches the author or committer

A valid sign-off was found in the commit message, but it doesn't match neither the author nor the committer. Make sure that both the name and email in the sign-off line match the author or committer of the commit.

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~250 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin main