fix: linter #3997
fix: linter #3997
Conversation
|
Dear @Anshumancanrock thank you very much for your contribution! Could you please squash your commits and fix the DCO (instructions here https://github.com/hyperledger-cacti/cacti/pull/3997/checks?check_run_id=51126846498)? |
Anshumancanrock
force-pushed
the
main
branch
from
89a011b to
608a8d0
Compare
Signed-off-by: anshumancanrock <[email protected]> fix lint Signed-off-by: anshumancanrock <[email protected]>
Anshumancanrock
force-pushed
the
main
branch
from
608a8d0 to
4016559
Compare
|
Sir @RafaelAPB Thanks for the feedback! I have squashed the commits and added the proper DCO sign-off. The PR should now pass all checks. Let me know if you need any other changes. |
There was a problem hiding this comment.
@Anshumancanrock, can you check the CI, please? [Cactus_CI / build-dev (pull_request)](https://github.com/hyperledger-cacti/cacti/actions/runs/17985622383/job/51251503165?pr=3997)
The failure appears to be from the changes you made.
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| verifySignature(obj: any, pubKey: string): boolean { | ||
| verifySignature(obj: IRemoteLog, pubKey: string): boolean { |
There was a problem hiding this comment.
This is making the CI fail.
The signature verification shouldn't be from the IRemoteLog, this is used to verify the requests/responses of the SATP messages protocol.
Fixes: #3984
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.