fix(weaver): resource incorrect permission assignment #3942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicboy0322
requested review from
AndreAugusto11,
RafaelAPB,
TheJagpreet,
VRamakrishna,
izuru0,
outSH,
sandeepnRES and
takeutak
as code owners
sandeepnRES
reviewed
Jul 8, 2025
| outputDir.setExecutable(false, false); | ||
| // add all privilege to owner | ||
| outputDir.setReadable(true, true); | ||
| outputDir.setWritable(true, true); |
There was a problem hiding this comment.
@sandeepnRES Fixed the indentation. Thanks for pointing it out!
sandeepnRES
approved these changes
Jul 8, 2025
|
Approved, but please fix the above identation before merging. |
musicboy0322
force-pushed
the
fix/issue2769
branch
from
f7ff0b9 to
552a9e9
Compare
|
@outSH @RafaelAPB @izuru0 can any of you please review this PR, so that we can merge it? Thanks. |
outSH
approved these changes
Aug 26, 2025
|
@sandeepnRES @musicboy0322 the PR is approved but needs a rebase. |
Primary change: Grant full permissions to owner only Fixes hyperledger-cacti#2769 Signed-off-by: musicboy0322 <[email protected]>
musicboy0322
force-pushed
the
fix/issue2769
branch
from
552a9e9 to
e0a1337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change: Grant full permissions to owner only
Fixes #2769
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.