Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change github org from hyperledger to hyperledger-cacti #3579

Merged

Conversation

petermetz
Copy link
Contributor

The diff here came to be by doing a simple search & replace repo-wise
where "https://github.com/hyperledger/cacti/" got replaced with
"https://github.com/hyperledger-cacti/cacti/"

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@VRamakrishna
Copy link
Contributor

VRamakrishna commented Oct 9, 2024

@petermetz If Ry is going to add a redirect from github.com/hyperledger/cacti to github.com/hyperledger-cacti/cacti, are these changes still required?

I'm asking because we intend to (at some point) migrate the repo over again to the lf-decentralized-trust organization, right?

Otherwise, changes LGTM.

@petermetz
Copy link
Contributor Author

@petermetz If Ry is going to add a redirect from github.com/hyperledger/cacti to github.com/hyperledger-cacti/cacti, are these changes still required?

I'm asking because we intend to (at some point) migrate the repo over again to the lf-decentralized-trust organization, right?

Otherwise, changes LGTM.

@VRamakrishna I'd say regardless of what happens in the near future, it's best to keep the docs links as up to date as possible to demonstrate project liveness.
The redirections could end up being turned off later through some unintended side-effect of a configuration change.
I'm happy to send another PR if/when we migrate to the LFDT org.

The diff here came to be by doing a simple search & replace repo-wise
where "https://github.com/hyperledger/cacti/" got replaced with
"https://github.com/hyperledger-cacti/cacti/"

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the docs-migrate-to-new-github-org branch from e16d885 to c8c71cf Compare October 15, 2024 00:01
@petermetz petermetz merged commit a4ec611 into hyperledger-cacti:main Oct 15, 2024
142 of 145 checks passed
@petermetz petermetz deleted the docs-migrate-to-new-github-org branch October 15, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants