Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): add workflow for DCO check #3303

Merged

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz
Copy link
Contributor Author

CC: @ryjones

@petermetz petermetz requested a review from RafaelAPB June 10, 2024 17:31
@petermetz petermetz force-pushed the ci-new-dco-github-action-job branch from b5a091d to 6322ee5 Compare June 10, 2024 17:35
@ryjones
Copy link
Contributor

ryjones commented Jun 10, 2024

@petermetz I've updated the rules to accept either as valid for now.

@petermetz
Copy link
Contributor Author

@petermetz I've updated the rules to accept either as valid for now.

@ryjones Got it, thank you!

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz force-pushed the ci-new-dco-github-action-job branch from 6322ee5 to b6215bc Compare June 14, 2024 15:25
@petermetz petermetz merged commit 092d450 into hyperledger-cacti:main Jun 14, 2024
145 of 150 checks passed
@petermetz petermetz deleted the ci-new-dco-github-action-job branch June 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants