This repository has been archived by the owner on Feb 8, 2021. It is now read-only.
add dax support #495
Open
add dax support #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
reviewed
Apr 27, 2017
There was a problem hiding this comment.
qemu docs says
- "slots=$N" should be equal to or larger than the total amount of
normal RAM devices and vNVDIMM devices, e.g. $N should be >= 2 here.
Do we need to specify additional ram slots when adding nvdimm? It looks like the guest only has one slot currently:
root@ubuntu-fio-2760258893:/# lshw -class memory
*-firmware
description: BIOS
vendor: Bochs
physical id: 0
version: Bochs
date: 01/01/2011
size: 96KiB
*-memory
description: System Memory
physical id: 1000
size: 128MiB
capacity: 128MiB
*-bank
description: DIMM RAM
physical id: 0
slot: DIMM 0
size: 128MiB
width: 64 bits
hypervisor/qemu/qemu.go
Outdated
| Execute: "human-monitor-command", | ||
| Arguments: map[string]interface{}{ | ||
| "command-line": "object_add memory-backend-file,id=mem" + strconv.Itoa(blockInfo.PmemId) + | ||
| ",share=off,mem-path=" + filename + ",size=" + strconv.FormatInt(size, 10), |
There was a problem hiding this comment.
qemu docs says
"share=off", then guest writes won't be applied to the backend
file and thus will be invisible to other guests.
Does it mean all guest modification to rootfs will be lost?
|
updated. Hypervisor=qemu # or # Hypervisor=libvirt |
|
"EnableNvdimm" needs to be added to BootConfig. otherwise the PR breaks cases with the older qemus. |
Signed-off-by: Lai Jiangshan <[email protected]>
|
@laijs should we close this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lai Jiangshan [email protected]