qemu: only close tap fd on addnic failure

It causes various bizarre CI failures mostly pulling image failures. Signed-off-by: Peng Tao <[email protected]>
hyperhq · Oct 13, 2017 · 8292ffb · 8292ffb
1 parent 54ad407
commit 8292ffb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/hypervisor/qemu/qemu.go b/hypervisor/qemu/qemu.go
@@ -283,10 +283,13 @@ func (qc *QemuContext) AddNic(ctx *hypervisor.VmContext, host *hypervisor.HostNi
 	go func() {
 		// close tap file if necessary
 		ev, ok := <-waitChan
-		syscall.Close(fd)
 		if !ok {
+			syscall.Close(fd)
 			close(result)
 		} else {
+			if _, ok := ev.(*hypervisor.DeviceFailed); ok {
+				syscall.Close(fd)
+			}
 			result <- ev
 		}
 	}()