fix: Fix editing search tiles in dashboard #820
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -359,12 +359,16 @@ export function SQLInlineEditorControlled({ | |||
| }: Omit<SQLInlineEditorProps, 'value' | 'onChange'> & UseControllerProps<any>) { | |||
| const { field } = useController(props); | |||
|
|
|||
| // Guard against wrongly typed values | |||
| const value = field.value || props.defaultValue; | |||
| const stringValue = typeof value === 'string' ? value : ''; | |||
There was a problem hiding this comment.
we can merge this as-is, would it be appropriate to throw a warn here to understand when the component is being misused or is this largely doing null checks and the like?
There was a problem hiding this comment.
this is mainly for the select field as it can be array. I added a console.error to make sure we get notified if that happens again
…hes-after-editing
kodiakhq
bot
deleted the
ernest/hdx-1716-bug-dashboard-search-tile-crashes-after-editing
branch
Fix the issue with
selectfield becoming an empty array for Search tiles.