fix: alerting time range filtering bug #814
Merged
+187
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c39ffeb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
commented
May 14, 2025
Comment on lines
+688
to
693
| { | ||
| ServiceName: 'api', | ||
| Timestamp: eventNextMs, | ||
| SeverityText: 'error', | ||
| Body: 'Oh no! Something went wrong!', | ||
| }, |
There was a problem hiding this comment.
this new log line should test out the time boundary logic
wrn14897
commented
May 15, 2025
| @@ -716,6 +722,8 @@ export const processAlert = async (now: Date, alert: EnhancedAlert) => { | |||
| connection: connectionId, | |||
| displayType: DisplayType.Line, | |||
| dateRange: [checkStartTime, checkEndTime], | |||
| dateRangeStartInclusive: true, | |||
| dateRangeEndInclusive: false, | |||
There was a problem hiding this comment.
for alerts, we don't want to include the end of date range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: HDX-1701