Custom separator #48
Open
Custom separator #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Sep 28, 2021
| @@ -4,7 +4,7 @@ module.exports = Get | |||
|
|
|||
| function Get (db, key, opts, cb) { | |||
| this._db = db | |||
| this._node = new Node({key, flags: (opts && opts.hidden) ? Node.Flags.HIDDEN : 0}, 0, null, db.hash) | |||
| this._node = new Node({key, flags: (opts && opts.hidden) ? Node.Flags.HIDDEN : 0}, 0, null, db.hash, opts.sep) | |||
There was a problem hiding this comment.
Wouldnt it be easier just to load this from the db instance? It's not really configurable per node/iterator anyway, but more of a db wide thing.
There was a problem hiding this comment.
Then we don't need all the options updates
There was a problem hiding this comment.
Yes sounds good! I'll work on this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set an option
{ sep : mySeparator }when creating ahypertrie. This for instances allows to useBuffer.alloc(1)as a separator as when creating asubhyperbee.The test file is just the
iterator.jstest suite usingBuffer.alloc(1)as a separator.