docs(demo): tighten EPDS_CLIENT_THEME e2e note per PR #145 review#146
Conversation
- Drop the misleading "@client-branding" tag reference (no such tag
exists; copilot caught this) and reference the file path instead.
- Replace the malformed "expect(html).toContain('...')" snippet with
the actual playwright error substring a contributor would see in
their failure output (coderabbit flagged the quote/paren mismatch).
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
🚅 Deployed to the ePDS-pr-146 environment in ePDS
|
|
There was a problem hiding this comment.
Pull request overview
Doc-only tweak to the demo app’s .env.example guidance so contributors can reliably find and run the client-branding E2E coverage locally, using accurate repo references and a realistic Playwright failure substring.
Changes:
- Replaced the nonexistent
@client-brandingtag reference with a direct pointer tofeatures/client-branding.feature. - Updated the example failure text to match the actual Playwright error substring contributors will see/grep for.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25232647186Coverage remained the same at 53.156%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
Two cosmetic fixes to the
EPDS_CLIENT_THEMEnote added in PR #145, raised by review bots after that PR had already merged. Doc-only.@client-brandingtag, but no such tag exists in the repo.features/client-branding.featurescenarios use@untrusted-clientand@pendingonly. Reworded to "the client-branding e2e feature locally (see features/client-branding.feature)" so a contributor can find it directly.expect(html).toContain('body { background: \#1a1208`')snippet had quote/paren mismatch and wouldn't match a real failure log anyway. Replaced with the actual playwright error substring:Expected substring: "body { background: #1a1208"` — what a contributor actually sees and would grep for.Test plan
features/client-branding.featurecarries no@client-brandingtag.🤖 Generated with Claude Code
Summary by CodeRabbit