Version hyper-nano binaries and place artifacts in the current working directory #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd __hyper__ directory #537" BREAKING CHANGE: the __hyper__ directory and the hyper-nano binary will now be placed in the current working directory. Both should be added to a .gitignore so that they are not committed to source control
…ogic BREAKING CHANGE: the binaries are no longer overwritten in s3 on every publish. This will allow for each version of hyper-nano to use a specific unchanging binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
closes #537
This PR changes
hyper-nanoon Node to download the hyper-binary into the current working directory, which is to say wherevernpxis ran from, typically the project directory. This is similar behavior to tools like the NextJS CLI when runningnext build.With this, installing dependencies with
yarnwill not blow away the binary and any persisted data in the__hyper__directory, as described in #537This is breaking change, since users will need to add the
hyper-nanobinary and the__hyper__directory to their.gitignore.This PR also makes new versions of
hyper-nanobe published to our S3 bucket with a version suffix. This way, eachhyper-nanoversion has a corresponding binary version to be downloaded from S3.