fix(app-express): only treat getObject as iterable if not requesting …

…a signed url
hyper63 · May 24, 2023 · 7af3d2d · 7af3d2d
1 parent 1b9d08b
commit 7af3d2d
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/packages/app-express/api/storage.ts b/packages/app-express/api/storage.ts
@@ -186,8 +186,15 @@ export const storage = (services: HyperServices) => (app: Server) => {
   app.get<NameParams>(
     '/storage/:name/*',
     bindCore(services),
-    ({ params, query, storage }, res) =>
-      fork(
+    ({ params, query, storage }, res) => {
+      /**
+       * If the request is wanting a signedUrl
+       * Then we know the request will be JSON containing the signedUrl
+       * not an iterable
+       */
+      const isIterable = !isTrue(query.useSignedUrl)
+
+      return fork(
         res,
         200,
         storage
@@ -217,8 +224,9 @@ export const storage = (services: HyperServices) => (app: Server) => {
             const readableStream = result
             return readableStream
           }),
-        true,
-      ),
+        isIterable,
+      )
+    },
   )
 
   app.delete(