Skip to content

Conversation

@ikeough
Copy link
Contributor

@ikeough ikeough commented Mar 23, 2022

BACKGROUND:
Some users of Elements have asked for Model to implement an interface (see #694).

DESCRIPTION:
This PR introduces the IModel interface and implements the interface in the existing Model class. It also refactors model extension methods into a separate file and cleans up unused namespaces (which will pay dividends in the transition to System.Text.Json).

TESTING:
No code was changed.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@ikeough ikeough requested a review from andrewheumann March 23, 2022 05:10
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one stray comment

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ikeough)


Elements/src/Model.cs, line 59 at r2 (raw file):

        }

        /// <summary>O

O?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants