Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude pyRevitLabs from JSON Convert #1091

Merged
merged 2 commits into from
Feb 3, 2025
Merged

exclude pyRevitLabs from JSON Convert #1091

merged 2 commits into from
Feb 3, 2025

Conversation

jamesbradleym
Copy link
Contributor

@jamesbradleym jamesbradleym commented Feb 3, 2025 •
edited by andrewheumann
Loading

BACKGROUND:

  • We were encountering dll exceptions due to a dependency in the unit test of pyRevit beta 5. We don't need to pull in pyRevit types, so let's exclude them.

DESCRIPTION:

  • Excludes pyRevit from App Domain Assemblies used in Json convert.

TESTING:

  • Tested by importing any pringle model with Revit 2025 and pyRevit beta 5.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@jamesbradleym jamesbradleym requested a review from wynged February 3, 2025 17:20
wynged
wynged approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@jamesbradleym jamesbradleym merged commit a379d25 into master Feb 3, 2025
2 checks passed
@jamesbradleym jamesbradleym deleted the exclude-pyRevitLabs branch February 3, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbradleym @wynged