Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle missing exc_info in ExceptionDictTransformer #657

Conversation

yaelmi3
Copy link
Contributor

@yaelmi3 yaelmi3 commented Sep 25, 2024

  • Added a new utility function is_missing_exc_info to check if exc_info is missing.
  • Updated ExceptionDictTransformer to return an empty list when exc_info is missing.
  • Modified _format_exception to use the new is_missing_exc_info function.
  • Added a test case to verify that ExceptionDictTransformer returns an empty list when exc_info is missing.

#656

Summary

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • New APIs are added to our typing tests in api.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@hynek hynek force-pushed the issue-656-handle-empty-exc_info-in-ExceptionDictTransformer branch 2 times, most recently from d271e70 to e342def Compare October 12, 2024 13:28
yaelmi3 and others added 2 commits October 13, 2024 23:42
- Added a new utility function is_missing_exc_info to check if exc_info is missing.
- Updated ExceptionDictTransformer to return an empty list when exc_info is missing.
- Modified _format_exception to use the new is_missing_exc_info function.
- Added a test case to verify that ExceptionDictTransformer returns an empty list when exc_info is missing.
@yaelmi3 yaelmi3 force-pushed the issue-656-handle-empty-exc_info-in-ExceptionDictTransformer branch from e342def to 81bd8aa Compare October 13, 2024 20:42
tests/test_tracebacks.py Outdated Show resolved Hide resolved
Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the gift that keeps giving – thanks!

@hynek hynek merged commit 6f9ed85 into hynek:main Nov 9, 2024
19 checks passed
hynek added a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants