Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddCallingClassPath processor added #567

Closed
wants to merge 16 commits into from

Conversation

pahrohfit
Copy link
Contributor

@pahrohfit pahrohfit commented Oct 30, 2023

Summary

Added a class_path event entry processor as AddCallingClassPath (fixes #386, fixes #492).

Takes an optional set or list to limit which logging levels to add this at, as lookups potentially can add overhead (though should run in N(1)).

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!

    There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.

    This is not a pre-requisite for your your pull request to be accepted, but you have been warned.

  • Added tests for changed code.

    • The CI fails with less than 100% coverage.
  • New APIs are added to our typing tests in api.py.

  • Updated documentation for changed code.

    • New functions/classes have to be added to docs/api.rst by hand.

    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.

      The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.

  • Documentation in .rst and .md files is written using semantic newlines.

  • Changes (and possible deprecations) are documented in the changelog.

  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@pahrohfit pahrohfit closed this Oct 30, 2023
@hynek
Copy link
Owner

hynek commented Oct 30, 2023

Welcome to the "Why always open PRs from branches" lesson we all have to learn. :( Sorry for the pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants