-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddCallingClassPath
processor added
#567
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Welcome to the "Why always open PRs from branches" lesson we all have to learn. :( Sorry for the pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a
class_path
event entry processor asAddCallingClassPath
(fixes #386, fixes #492).Takes an optional
set
orlist
to limit which logging levels to add this at, as lookups potentially can add overhead (though should run in N(1)).Pull Request Check List
Do not open pull requests from your
main
branch – use a separate branch!There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
Added tests for changed code.
New APIs are added to our typing tests in
api.py
.Updated documentation for changed code.
New functions/classes have to be added to
docs/api.rst
by hand.Changed/added classes/methods/functions have appropriate
versionadded
,versionchanged
, ordeprecated
directives.The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
Documentation in
.rst
and.md
files is written using semantic newlines.Changes (and possible deprecations) are documented in the changelog.
Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.