Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cache option #6

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: use cache option #6

merged 2 commits into from
Jul 22, 2024

Conversation

henryiii
Copy link
Contributor

Close #5. See tomerfiliba/plumbum#684 for an example of using it.

Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve added some contents but as said before I think the idea is sound!

One think tho: I’m in the middle of Pantanal and am emphatically afk (brought no real computer) so my next opportunity to release is by the end of June. I could add you as a maintainer if you want one earlier tho.

oh wait and is there a changelog? Phone reviews are ughhh

README.md Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

henryiii commented Jun 4, 2024

Haha, no rush at all (if you can't tell!). :) End of month is fine. It can be worked around, it's just a nice quality of life improvement. I'll try to address the suggestions above in the next couple of days.

@henryiii
Copy link
Contributor Author

Ah, totally forgot about this. To be fair, I've been out with conjunctivitis for the last week+. I'll address these.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Contributor Author

I've addressed everything but the ./action comment.

Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thank you!

@hynek hynek merged commit c8e7913 into hynek:main Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: if statement for caching
2 participants