Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workflow and jobs names part of the cache key #10

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

hynek
Copy link
Owner

@hynek hynek commented Jul 26, 2024

No description provided.

@hynek
Copy link
Owner Author

hynek commented Jul 26, 2024

hm @henryiii would you agree that it would be better if GitHub.job were part of the default suffix? That's ultimately what 99.999% of people want and 90% of them will forget to do the right thing, so maybe we should?

@hynek
Copy link
Owner Author

hynek commented Jul 26, 2024

Or to rephrase: how important is it to share caches between jobs?

I feel like if it's that important, we should rather add an absolute cache-key input to let people completely override it.

@hynek hynek changed the title Try using GitHub.job to dedup Make workflow and jobs names part of the cache key Jul 26, 2024
@hynek hynek force-pushed the try-unique branch 3 times, most recently from 7757c81 to e627e37 Compare July 26, 2024 06:54
@hynek hynek merged commit 051aa61 into main Jul 26, 2024
6 checks passed
@hynek hynek deleted the try-unique branch July 26, 2024 07:49
@henryiii
Copy link
Contributor

Yes, I think this makes sense.

@hynek
Copy link
Owner Author

hynek commented Jul 26, 2024

jftr, I've also added a weekly cache in #11 bust and bumped major so nobody can complain. the cache bust can be easily disabled tho

@henryiii
Copy link
Contributor

I thought it already has an timeout of a week built in? Oh, I guess the difference is that the built-in one will evict the cache if it hasn’t been touched in a week, while this will evict every week?

@hynek
Copy link
Owner Author

hynek commented Jul 26, 2024

yep exactly! the built-in one doesn't expire if you access it every 5.5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants