Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra \\ at load string on external-libraries.json entries #22

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

munshkr
Copy link
Contributor

@munshkr munshkr commented Jan 13, 2024

There is an extra escaped \ between the double quotes of the library URL, which when importing it, it inserts the code like this:

await loadScript(\"https://threejs.org/build/three.js\")

instead of

await loadScript("https://threejs.org/build/three.js")

There is an extra escaped `\` between the double quotes of the library URL, which when importing it, it inserts the code like this:

```javascript
await loadScript(\"https://threejs.org/build/three.js\")
```

instead of

```javascript
await loadScript("https://threejs.org/build/three.js")
```
@ojack ojack merged commit fa3c58e into hydra-synth:main Jan 13, 2024
1 check passed
@munshkr munshkr deleted the patch-1 branch January 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants