fix(router): prevent from throwing when browser pushes null state

hybridsjs · May 14, 2024 · 3208959 · 3208959
1 parent a5645d6
commit 3208959
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/router.js b/src/router.js
@@ -381,7 +381,7 @@ function setupView(hybrids, routerOptions, parent, nestedParent) {
           return params;
         },
         (host, params, lastParams) => {
-          if (!lastParams) return;
+          if (!lastParams || !globalThis.history.state) return;
 
           const state = globalThis.history.state;
           const index = state.findIndex((entry) => {

diff --git a/test/spec/router.js b/test/spec/router.js
@@ -634,6 +634,19 @@ describe("router:", () => {
         });
       });
 
+      it("does not throw when browser pushes null state", () => {
+        const state = window.history.state;
+        window.history.replaceState(null, "", "");
+        const rootView = host.views[0];
+        rootView.globalB = "value";
+
+        return resolveTimeout(() => {
+          expect(hybrids(host.views[0])).toBe(RootView);
+          expect(hybrids(host.children[0])).toBe(RootView);
+          window.history.replaceState(state, "", "");
+        });
+      });
+
       it("displays root view", () =>
         resolveTimeout(() => {
           expect(hybrids(host.views[0])).toBe(RootView);