Add logs using logs
#223
Merged
Add logs using logs
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More logs can be added if #222 is accepted and merged, so I leave this PR in draft for now. |
brotskydotcom
requested changes
Oct 13, 2024
There was a problem hiding this comment.
- If you change the dependency to be on the
logscrate, then you won't have to conditionalize the logging code at all, which will provide an enormous simplification. (See my comments on Add logs support #221 for other reasons I prefer logs to tracing.) - When creating an entry, please be sure to log the credential-store-specific attributes being used as well as the credential store. (Since all of the stores derive Debug, you can just debug print the credential into the log.)
- When operating on an entry, be sure to debug log the entry. That way it can be correlated to where the entry was created.
- I suggest you move logging of the target, service, and user into the platform-independent code, which saves you adding it to the credential-store code. Then the credential-store code can just debug log the credential being operated on.
Closed
soywod
force-pushed
the
tracing
branch
2 times, most recently
from
303424b to
6dd0633
Compare
Also used env_logger for tests.
|
The PR is ready for review. In fact it can be mergde before or after #222, it does not matter. I try to apply what you asked for, let me know if it's what you have in mind. I added |
brotskydotcom
requested changes
Oct 15, 2024
brotskydotcom
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Perfect! Thanks so much for this! I will merge it right away, so you can rebase #222 on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221.
This PR adds basic log support using the
tracingcrate. It gives more context to users about what is going on insidekeyring-rs.