Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issues #11

wants to merge 1 commit into from

Conversation

andreastr99
Copy link

I've solved 3 issues:

  • The Player class does not satisfy the good practices of code writing. The name and value fields must be private and must be used by getters/setters to work with them outside of the class.
  • When the game starts if you press the back button you quit the app and the game must start all over. You could use the Toast class to appear a message on the screen to warn the user that he’s going to quit the app.
  • Another issue that I spotted is that when you using the app you can’t start over the game unless you quit the app or finish the game. For that thing, you could add a replay button to let the user start again the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant