Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support rollup output.name and output.extend option #535

Closed
wants to merge 1 commit into from

Conversation

aliothor
Copy link

  1. update pnpm to v9.1.3
  2. support rollup output.name and output.extend option, link

Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR. Right now bunchee is not actively adding features for iife or umd formats. I'm unclear what's the case that we need to support them.
It's good to recommend users to use the zero arguments build approach. Alsoname can come from package.name and extend option seem can remain as default.

The pr is missing intention in PR description and examples. There're also a lot of other changes are unrelated to the feature and missing test. I'd love to see some explaination for the scenarios that we need to support them and then we decide wether to add those cli args.

@@ -116,5 +116,5 @@
],
"testTimeout": 60000
},
"packageManager": "pnpm@8.8.0"
"packageManager": "pnpm@9.1.3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's separate the pnpm bump into a new PR 👍

@huozhi huozhi closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants