Revert to using quiescing helper #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
quiescing-helper
branch
from
0d2df0e
to
d9bdcae
Compare
Joannis
reviewed
May 29, 2024
adam-fowler
force-pushed
the
quiescing-helper
branch
from
d9bdcae
to
1b226da
Compare
|
This fixes #503 |
|
Can we get a test to reproduce #503 in this PR? |
|
Was just thinking that |
Added |
Joannis
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can quiesce channels outside of the handle task. Required for channels which involve an upgrade path before passing to concurrency handlers.