Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for writing informational headers #196

Closed
wants to merge 1 commit into from

Conversation

adam-fowler
Copy link
Member

Added HBRequest.writeInformationalResponse.
Used for writing 1xx status codes

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24 ⚠️

Comparison is base (bac6817) 84.68% compared to head (2743014) 84.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   84.68%   84.44%   -0.24%     
==========================================
  Files          77       77              
  Lines        4531     4545      +14     
==========================================
+ Hits         3837     3838       +1     
- Misses        694      707      +13     
Impacted Files Coverage Δ
...Hummingbird/Server/Application+HTTPResponder.swift 91.17% <0.00%> (-8.83%) ⬇️
Sources/Hummingbird/Server/Request.swift 77.65% <0.00%> (-10.30%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler
Copy link
Member Author

Damn realised I can't do this as I don't send a request until I have at least one body part

@adam-fowler adam-fowler deleted the informational-response branch August 15, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant