Add input to specify windows architecture target to build vulkan-1.lib #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
July 28, 2023 14:34
Major: - windows-latest is windows-2022 so it requires Visual Studio 17 2022
Major: - reverting atempting ci test correction since it should be the issue.
Minor: - Fixed if statement parenthesis
That's because Win32 is the default value we will use in Windows systems arch matrix in other github actions
|
(half a year later... apologies for delay reviewing!) This is really great! In the back of my mind I remember wanting to keep the For now I will plan on leaving this PR open as a reference and hope to find more time coming up to look into the best way to integrate/merge the enhanced feature into mainline. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I know it's probably a minor set of the users but I needed to make sure that my project using Vulkan would also compile for Win32. This didn't seem to be covered by your action as I understood everything was set to x64 by default; I hope I didn't miss anything. If you think it's too specific, feel free to leave it pending. At least, I wanted to share my solution for the few people that might be interested.
I added an optional input to be able to select x64 or Win32 with a description mentioning that this is relevant for windows only. Then, there is a catch: vsdevenv can be set with x86 but not Win32, so I added a step in the action to translate the arch to x86 in the only case that user want to set up vulkan for Win32.
The windows test for powershell was replaced with a test including the arch.
P.S. I am sorry, the intermediate tests were a bit messy and I didn't know about action-tmate until 10min ago...