Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SDK] getLeaders function #876

Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: [SDK] getLeaders function #876

merged 2 commits into from
Sep 7, 2023

Conversation

leric7
Copy link
Collaborator

@leric7 leric7 commented Sep 7, 2023

Description

We need to use subgraph to get leader details.

Summary of changes

  • Removed getAllStakers, and getStaker function from StakingClient.
  • Added getLeaders, and getLeader function instead, which reads data from subgraph.
  • Removed e2e test of python SDK.

How test the changes

Related issues

Keywords for linking issues

Closes #868

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 0:38am

@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 7, 2023 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 7, 2023 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 7, 2023 12:16 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 7, 2023 12:17 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 7, 2023 12:18 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 7, 2023 12:18 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 7, 2023 12:33 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 7, 2023 12:33 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 7, 2023 12:34 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 7, 2023 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 7, 2023 12:37 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 7, 2023 12:38 Inactive
Copy link
Contributor

@m00n620 m00n620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leric7 leric7 merged commit bc62446 into develop Sep 7, 2023
13 of 15 checks passed
@leric7 leric7 deleted the feat/subgraph-leader branch September 19, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants