[Job launcher] Added enums parsing #2610
Open
+3,933
−563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
portuu3
requested changes
Oct 8, 2024
There was a problem hiding this comment.
I think you should use an interceptor instead of a validator, in the end you don't want to validate, what you need is to convert any enum value received (upper or lower case) to the case defined in the internal enums (lowercase). Also using an interceptor I think might be possible to use it as a middleware and affect to all enums instead of having to specify it for all dtos.
packages/apps/job-launcher/server/src/common/decorators/enum-insensitive.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/common/decorators/enum-insensitive.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/job/job.controller.ts
Outdated
Show resolved
Hide resolved
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
portuu3
requested changes
Oct 9, 2024
packages/apps/job-launcher/server/src/common/interceptors/enum-insensitive.ts
Outdated
Show resolved
Hide resolved
...pps/job-launcher/server/src/database/migrations/1728411922919-updateEnumValuesToLowerCase.ts
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/auth/auth.service.ts
Outdated
Show resolved
Hide resolved
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
portuu3
previously approved these changes
Oct 10, 2024
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
* Added enum parsing * Updated solution error * Lint fix * Lint fix * Updated interceptor * Lint fix * Updated imports
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
* Added enums parsing * Update decorator export * Moved decorator
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
* Implemented enum parsing for exchange oracle * Updated lint * Updated decorator and interceptor * Resolved conflicts * Add guards * Update decorator export * Deleted console.log
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
* Added enums parsing * Improved interceptor * Removed comments
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added enums parsing.
Summary of changes
Implemented@isEnumInsensitivedecorator.Implemented unit tests for decorator.EnumTransformInterceptorinterceptor.JobControllerunit tests.How test the changes
yarn testRelated issues
Enums parsing #2600