remove 0x from hash comparison (#2530)

humanprotocol · Sep 19, 2024 · 70faf20 · 70faf20
1 parent 525eb5b
commit 70faf20
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/sdk/python/human-protocol-sdk/human_protocol_sdk/kvstore/kvstore_utils.py b/packages/sdk/python/human-protocol-sdk/human_protocol_sdk/kvstore/kvstore_utils.py
@@ -198,7 +198,10 @@ def get_file_url_and_verify_hash(
         content = requests.get(url).text
         content_hash = Web3.keccak(text=content).hex()
 
-        if hash != content_hash:
+        formatted_hash = hash.replace("0x", "")
+        formatted_content_hash = content_hash.replace("0x", "")
+
+        if formatted_hash != formatted_content_hash:
             raise KVStoreClientError(f"Invalid hash")
 
         return url

diff --git a/packages/sdk/typescript/human-protocol-sdk/src/kvstore.ts b/packages/sdk/typescript/human-protocol-sdk/src/kvstore.ts
@@ -464,7 +464,10 @@ export class KVStoreUtils {
     const content = await fetch(url).then((res) => res.text());
     const contentHash = ethers.keccak256(ethers.toUtf8Bytes(content));
 
-    if (hash !== contentHash) {
+    const formattedHash = hash?.replace(/^0x/, '');
+    const formattedContentHash = contentHash?.replace(/^0x/, '');
+
+    if (formattedHash !== formattedContentHash) {
       throw ErrorInvalidHash;
     }