Create CloudFront Function and Origin Request Policy #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will create a cloudfront function and request policy along with each distribution, as we're limited on the amount of associations. We _also_ have total limits on policies and functions, so we will likley need to follow this up with being able to link mulitple distributions to a single policy and function, and batch it every 100.
|
This is pending the max limits we can get from AWS |
Rayhatron
reviewed
Dec 16, 2024
| 'CookieBehavior' => 'whitelist', | ||
| 'Cookies' => [ | ||
| 'Quantity' => 3, | ||
| 'Items' => [ |
There was a problem hiding this comment.
Could the cookies list be made filterable to allow for custom cookies to be added to the list when the request policies are created?
I know if that list does ever change then we'd need to either manually update the policy via AWS console or possibly introduce another function for updating policies using the plugin for that use case. Just thinking about that first time policy creation given there can potentially be multiple policies to be created and would be good to have other cookies already included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create a cloudfront function and request policy along with each distribution, as we're limited on the amount of associations.
We also have total limits on policies and functions, so we will likley need to follow this up with being able to link mulitple distributions to a single policy and function, and batch it every 100.