Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InnerBlockSlider: Select block when slide changes & change slide when selected block changes #209

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

mattheu
Copy link
Member

@mattheu mattheu commented Oct 23, 2023

This covers 2 small enhancements that improve the integration with the block editor and just make this a bit nicer to use.

  1. When changing to a new slide, select that slide block in the block editor state, ensuring the correct block is focused.
  2. When selecting a slide block externally, e.g. from the Document Overview panel, that slide should be set as current. Updated to handle selecting inner blocks too. Note a limitation is that it will not change if you select an inner block of an inner block, which would be nice to handle in future.

src/components/InnerBlockSlider/index.js Outdated Show resolved Hide resolved
src/components/InnerBlockSlider/index.js Outdated Show resolved Hide resolved
@tomjn tomjn added the enhancement New feature or request label Oct 25, 2023
@mattheu mattheu changed the title InnerBlockSlider: Select block when changes InnerBlockSlider: Select block when slide changes & change slide when selected block changes Oct 30, 2023
@tomjn tomjn merged commit 4cfe31a into main Dec 19, 2023
2 checks passed
@tomjn tomjn deleted the select-slide-on-change branch December 19, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants