Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak on indexing ES on local / dev / staging #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joehoyle
Copy link
Member

@joehoyle joehoyle commented Nov 28, 2024

Add a new function reset_elasticsearch_queries to handle the logic for resetting the Elasticsearch queries.

  • Add use ReflectionProperty at the top of the file and ensure all use statements are in alphabetical order
  • Hook the new function to the ep_stop_the_insanity action using add_action

For more details, open the Copilot Workspace session.

Add a new function `reset_elasticsearch_queries` to handle the logic for resetting the Elasticsearch queries.

* Add `use ReflectionProperty` at the top of the file and ensure all `use` statements are in alphabetical order
* Hook the new function to the `ep_stop_the_insanity` action using `add_action`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/humanmade/altis-enhanced-search?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minus the PHPCS complaints from the linter, I've tested and confirmed that this fix minimizes leak issues locally in a vanilla altis install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants