Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch XRay flamegraph to icicle graph to match Vantage #79

Open
roborourke opened this issue Jul 1, 2020 · 0 comments
Open

Switch XRay flamegraph to icicle graph to match Vantage #79

roborourke opened this issue Jul 1, 2020 · 0 comments
Labels
should have Should be done, medium priority for now

Comments

@roborourke
Copy link
Contributor

roborourke commented Jul 1, 2020 •
edited by rmccue
Loading

Way back, we switched the flamegraph in Vantage to an icicle graph and redid all the UI. But we never updated the Dev Tools version to use the same components or UI.

This should be updated to use this for consistency, and because the flamegraph provides a better user experience generally. One option would be to publish the component from Vantage to npm and import that in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
should have Should be done, medium priority for now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmccue @roborourke @yumito @jennybeaumont