Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare beta v1 #5

Merged
merged 15 commits into from
Feb 13, 2023
Merged

Prepare beta v1 #5

merged 15 commits into from
Feb 13, 2023

Conversation

jerico
Copy link
Contributor

@jerico jerico commented Jan 17, 2023

This PR prepares for a v1 beta release.

The following tasks were covered:

  • e779815 Renames altis command to altis-cli
  • 4ebd605 d767c1a Codebase is up to date with latest/current versions of Node.js
    • Dependencies were updated to address critical warning about vulnerabilities
    • Features were tested using Nodejs v18 LTS
  • 9196de5 altis-cli stack backup Fix to use correct API endpoint
  • 2f070c6 altis-cli stack deploy
    • Updates region-related code that was deprecated
    • Adds prompt to ask which build to deploy
    • The prompt also effectively addresses ability to rollback deployed builds- Add pr
  • ed7631f altis-cli stack scp
    • eb79ff6 Adds description and provided an example to proper use
    • Fixes local to remote upload was broken because the code checks for local existence of the remote destination. Fixed by pointing to the check to the local file.
  • f876634 acae494 9d67f45 98805a2 altis-cli stack local-setup
    • Add feature to clone existing Altis codebase from the dashboard and automatically run composer install
  • 9e0e77b Remove altis-cli stack sequel command
  • ed7a72b Update copyright year

More information described here: #2

Looking for early feedback and marked this PR as ready for review.

@jerico jerico marked this pull request as draft January 17, 2023 16:20
@jerico jerico mentioned this pull request Jan 18, 2023
11 tasks
README.md Outdated Show resolved Hide resolved
scp command checks the existence of a remote file using `fs.existsSync`
that's intended for local filesystem only. It always returns false and
uploading fails.

Fixed by checking if the source file exists instead.
This command relies on direct SSH access to the sandbox which vantage
doesn't support anymore.
This command will clone an existing Altis stack and run `composer install`.
@jerico jerico marked this pull request as ready for review January 23, 2023 09:26
Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. But I added a couple of questions

lib/commands/stack/local-setup.js Outdated Show resolved Hide resolved
lib/commands/stack/local-setup.js Outdated Show resolved Hide resolved
@jerico jerico requested a review from mikelittle February 7, 2023 04:14
Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Are there some docs on https://docs.altis-dxp.com/core/cli-command/ to update? (Probably needs a separate ticket.)

@rmccue
Copy link
Member

rmccue commented Feb 7, 2023

Are there some docs on https://docs.altis-dxp.com/core/cli-command/ to update? (Probably needs a separate ticket.)

That's for the wp-cli commands available in the Core module, which is a different "product" in this sense; we have #3 for docs for altis-cli specifically

@kovshenin
Copy link

Changes look okay to me (as far as my JavaScript expertise goes) but I'm having trouble testing this. I'm running npm install and then:

altis-cli (prepare-beta-v1) ✗ $ bin/altis-cli  
Welcome to hm-cli!

[hm logo]

? Run initial setup? Yes
TypeError: configure is not a function
    at /Users/kovshenin/altis-cli/bin/altis-cli:92:12
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node version:

altis-cli (prepare-beta-v1) ✗ $ node -v
v18.13.0

Any pointers?

@jerico
Copy link
Contributor Author

jerico commented Feb 10, 2023

@kovshenin I missed updating the setup sequence. My understanding is we have the "setup" process to configure developer's ssh keys to access the sandbox servers before. This has been remove and there's nothing to configure. I need to update this to point to Vantage authentication flow instead.

To trigger Vantage authentication, you can any task such as ./bin/altis-cli stack list and it will offer to authenticate if no token has been found.

I'll fix the initial setup issue.

@jerico
Copy link
Contributor Author

jerico commented Feb 13, 2023

@kovshenin My bad. I had a change in altis-cli itself but missed pushing. It is fixed now.

@jerico jerico merged commit b7d5108 into main Feb 13, 2023
@joehoyle joehoyle deleted the prepare-beta-v1 branch February 23, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants