-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare beta v1 #5
Conversation
scp command checks the existence of a remote file using `fs.existsSync` that's intended for local filesystem only. It always returns false and uploading fails. Fixed by checking if the source file exists instead.
This command relies on direct SSH access to the sandbox which vantage doesn't support anymore.
This command will clone an existing Altis stack and run `composer install`.
37c703c
to
f876634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. But I added a couple of questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Are there some docs on https://docs.altis-dxp.com/core/cli-command/ to update? (Probably needs a separate ticket.)
That's for the wp-cli commands available in the Core module, which is a different "product" in this sense; we have #3 for docs for |
Changes look okay to me (as far as my JavaScript expertise goes) but I'm having trouble testing this. I'm running altis-cli (prepare-beta-v1) ✗ $ bin/altis-cli
Welcome to hm-cli!
[hm logo]
? Run initial setup? Yes
TypeError: configure is not a function
at /Users/kovshenin/altis-cli/bin/altis-cli:92:12
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) Node version:
Any pointers? |
@kovshenin I missed updating the setup sequence. My understanding is we have the "setup" process to configure developer's ssh keys to access the sandbox servers before. This has been remove and there's nothing to configure. I need to update this to point to Vantage authentication flow instead. To trigger Vantage authentication, you can any task such as I'll fix the initial setup issue. |
@kovshenin My bad. I had a change in |
This PR prepares for a v1 beta release.
The following tasks were covered:
altis
command toaltis-cli
altis-cli stack backup
Fix to use correct API endpointaltis-cli stack deploy
altis-cli stack scp
altis-cli stack local-setup
composer install
altis-cli stack sequel
commandMore information described here: #2
Looking for early feedback and marked this PR as ready for review.