Replace ByteString with Buffer

[gordonmessmer]

Description

ByteString has been deprecated in Python since 3.9. It has been removed from the typing module, in 3.14. This change replaces ByteString with Buffer.

Checklist

• My code follows the code style of this project.
• My change includes a change to the documentation, if required.
• If my change adds new code, adequate tests have been added.
• I have read and agree to the CONTRIBUTING document.

[github-actions]

🤖 Coverage update for 416ebe5 🔴

	Old	New
Commit	ee605f9	416ebe5
Score	71.0775%	71.0582% (-0.0193)

[github-actions]

🤖 Coverage update for 38aafb3 🟢

	Old	New
Commit	ee605f9	38aafb3
Score	71.0775%	71.0775% (0)

[gordonmessmer]

When I apply this patch to gef and run the test suite on Fedora 42, I get two test failures. The relevant details should be in the attached file. I think the tests are looking for "Tcachebins" in the command output, but it isn't present. I'm not sure why that might happen.

Do you have any advice for how I might resolve those test failures?

FAILURES-HeapCommandNonMain.txt

[hugsy]

When I apply this patch to gef and run the test suite on Fedora 42, I get two test failures. The relevant details should be in the attached file. I think the tests are looking for "Tcachebins" in the command output, but it isn't present. I'm not sure why that might happen.

Do you have any advice for how I might resolve those test failures?

FAILURES-HeapCommandNonMain.txt

Hum 🤔

I can't think of a reason like that. I do remember having failures on Fedora (was prob. 40 or 41 at that time) when running extended testing but it seems unrelated.

I am on vacation now, don't have access to my pc but I investigate more later.

Note that for now, that won't prevent your PR to be merged as-is.

[gordonmessmer]

Sorry for the delay...

I made a mistake earlier... those test failures do not occur on Fedora 42, they occur on Fedora 43. I'm not positive, but I think tcachebin is a glibc implementation detail, so the errors might simply be a change in glibc's behavior in 2.42? That's only a guess. I have no real idea.

Everything else seems to work as expected with this change, both automatic tests and interactive use.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue.