-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use target remote
for remote connections
#1151
base: main
Are you sure you want to change the base?
Conversation
…y/gef into hugsy/revisit-target-remote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work pretty well even with an openocd gdb server. Will have to do more testing but we can probably remove the 'special' gef remote commands in gef-extras
docs/commands/gef-remote.md
Outdated
traditional `target remote` command. For many reasons, you **should not** use `target remote` alone | ||
with GEF. It is still important to note that the default `target remote` command has been | ||
overwritten by a minimal copy `gef-remote`, in order to make most tools relying on this command work. | ||
📝 **IMPORTANT NOTE**: `gef-remote` is deprecated since 2024.09 in favor of `target remote`. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it'll be the next release
# pre-hooks | ||
gdb.execute(hook.format("remote", "")) | ||
gdb.execute(hook.format("extended-remote", "")) | ||
# post-hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably OK if we update what versions of GDB are supported.
Description
This PR obsoletes
gef-remote
to be completely replaced by pre and post hooks ontarget remote
directly.We use some heuristics to determine what type of remote we're connected to reliably.
In some old qemu, we still have to mock a memory layout, but the whole
sync
thing is not necessary any longer.Fixes #1080
Fixes #1128
Checklist