A few performance improvements to XbMachine #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we must apply side-effects from parameters in g_log(), these will result in string formatting even through the log level may not currently include debug messages.
-Bsymbolic and no-plt so we are more likely to get direct function calls. Additionally disable "FOO_BAR()" style type checks on casting in release builds along with "g_assert()". Only for libxmlb, not any tests.
This gets a few things that are currently not getting inlined across modules into a form that can be inlined and optimized.
chergert
force-pushed
the
wip/chergert/machine-speedup
branch
from
1f7bd12 to
245a742
Compare
hughsie
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing crazy, just ensuring more things get inlined and allow for more compiler optimizations in surrounding code. Also
-Bsymbolicand-fno-pltlinker options.The bigger wins here will still be in making Software cache more XbQuery likely.
Related to #139