fix(vLLM): Add tool calling support to VLLMClient.chat() #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes huggingface#4871 Previously, using GRPOTrainer with `vllm_mode="server"` raised a `NotImplementedError` when tools were passed to `VLLMClient.chat()`. This prevented users from using tool calling features with the vLLM server mode. Changes: - Remove the NotImplementedError check in VLLMClient.chat() - Add `tools` parameter to the HTTP request payload - Add `tools` field to ChatRequest model in vllm_serve.py - Pass tools to vLLM's chat() method on the server side
kansalaman
force-pushed
the
fix-vllm-tool-calling
branch
from
2eeebac to
e6b226a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
VLLMClient.chat()for vLLM server modeChanges
NotImplementedErrorcheck for tools inVLLMClient.chat()toolsparameter to HTTP request payload in clienttoolsfield toChatRequestmodel in servertoolsto vLLM'schat()method on server sideTest plan
pytest tests/ -k "vllm" -v)