-
Notifications
You must be signed in to change notification settings - Fork 2.5k
make dpo compatible with qwen3vl #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks, can you add a test case using |
Of course, let me implement one. |
|
@qgallouedec could you help to do a code review for this request? |
One more thing: these three default values are all quite small. During actual training, it's easy to overlook setting these values, which can lead to errors. Do they need to be increased?
@qgallouedec
|
|
got that, thanks |
|
@qgallouedec |


What does this PR do?
Fixes # (issue)
make dpo compatible with qwen3vl
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.