Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor(prompt, images=image) to processor(images=image, text=prompt) #2076

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Sep 17, 2024

What does this PR do?

huggingface/transformers#32858 introduced a breaking change. The order of arg in processor must be reverted.

Cause of https://github.com/huggingface/trl/actions/runs/10899672686/job/30245604639#step:5:3406

Also added a missing commit from #2057: handle special case where model is str in BCOTrainer

Fixes the CI

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec merged commit c314383 into main Sep 17, 2024
10 checks passed
@qgallouedec qgallouedec deleted the fix-vlm branch September 17, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants