fix minor docs, testing, and npu detection issues - #47545
Closed
DhanushPillay wants to merge 6 commits into
Closed
Conversation
DhanushPillay
force-pushed
the
fix-docs-and-typos
branch
from
July 25, 2026 13:45
a128d55 to
6ed5c22
Compare
Contributor
|
Thank you for your contribution 🤗! CI Security Gate — automatic approval blockedThis PR was not automatically approved for CI because the security gate failed. Possible reasons:
See the workflow run for the exact violations. A maintainer can review and manually approve CI if a finding is a false positive. |
- compressed_tensors.py: return _IdentityOp from DecompressExperts.reverse_op - testing_utils.py: update NPU detection logic for torch 2.5.1 - trainer_seq2seq.py: remove temporary _from_model_config hack - i18n: rename Hindi translation to standard README_hi.md - docs: fix broken markdown links in cohere2_moe.md and examples/README.md
- Add getattr fallback for atol/rtol in GenerationTesterMixin.test_generate_with_static_cache - Override static_cache_generate_atol and static_cache_generate_rtol to 2e-4 in OlmoModelTest
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: olmo |
Contributor
CI recapDashboard: View test results in Grafana |
DhanushPillay
changed the title
Member
|
No agent PRs from first-time contributors! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and fixes across documentation, model integration utilities, device detection, and testing utilities. The most notable changes involve enhanced device detection for NPUs, improved flexibility in generation output comparison tests, and documentation corrections.
Device detection and integration improvements:
get_device_propertiesto usetorch.npu.is_available()for more reliable and consistent behavior, aligning with CUDA/XPU checks.DecompressExperts, thereverse_opproperty now returns an_IdentityOpinstead ofNone, addressing a previous FIXME and improving the conversion operation interface._IdentityOpimport tocompressed_tensors.pyto support the above change.Testing and configuration:
test_generate_with_static_cache, the test now uses instance attributes foratolandrtoltolerances, allowing model-specific overrides and improving test flexibility.OlmoModelTest, added higher tolerance values for static cache generation tests, accommodating expected numeric drift in these scenarios.Documentation fixes:
Other codebase maintenance:
generation_configinitialization intrainer_seq2seq.py, as part of ongoing codebase cleanup.